Registering Plugins With Decorators

I think I’ve missed something already explained. I wanted to ask about the different form of decorator here. Why does it not have include the inside wrapper function?

And now I’m wondering why we can’t do similar to the above all the time.

e.g.

Why can’t a decorator from before, such as:

def slow_down(func):
    """ Delay for 1 second """
    def wrapper_slow_down_one():
        time.sleep(1)
        return func()
    return wrapper_slow_down_one

not instead just be:

def slow_down(func):
    """ Delay for 1 second """
    time.sleep(1)
    return func

Hi Sam,

the different pattern used here for @register can be used when your decorator only needs to do something when the decorated function is defined, in this case it’s registered to a dictionary.

Since we’re not changing the function that has been passed in, that function will work exactly as if it had not been decorated. In the usual pattern, the decorated function is instead replaced by the inner wrapper function.

If you use your simplified @slow_down decorator, you will notice that the code sleeps for 1 second whenever you define a new decorated function, but it will not sleep when you call that decorated function.

Oh of course. Seems obvious now you say it. Ok, thank you.

I think there is no need to have return func in the def register(func). Correct me if I am wrong. Thanks

@levan8421 A decorator replaces the function being defined with what’s being returned from the decorator. If you don’t return func, the decorator is implicitly returning None. That would mean that the decorator would replace any function it decorates with None.

For example:

>>> def register(func):
...     print(f"registering {func}")
...
>>> @register
... def hello(name):
...     return f"Hello {name}"
...
registering <function hello at 0x7f432a989200>

>>> print(hello)
None

>>> hello("world")
TypeError: 'NoneType' object is not callable

Thank you for your response. I understand why decorator needs to return the func in general. I am just talking about this particular example of registering plugins:

import random
PLUGINS = dict()

def register(func):
    PLUGINS[func.__name__] = func

@register
def add(x):
    return x+5

def random_cal(x):
    func_name, func = random.choice(list(PLUGINS.items()))
    print(f'*** Using {func_name}')
    return func(x)

In the decorator **def register(func)**, the func is already added to PLUGINS and that is the sole purpose of this decorator. Later when we call the random_cal, the registered function will be called from the PLUGINS dictionary. That is why I think there would be no need to have *return func* in the def register(func). Of course, I would agree if it is for convention purpose.

@levan8421 True. In that particular example it works without returning the function, because you are only referencing the registered function through the PLUGINS dictionary.

However, it seems bound to cause issues later to have the decorator make the function uncallable directly, so I would still highly recommend returning func - even if your current code doesn’t use it.

Great video. LOLed on the “The func that comes in” :D